lkml.org 
[lkml]   [2020]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 00/12] Introduce threaded trace streaming for basic perf record operation
From
Date
Hi,

On 20.11.2020 12:45, Namhyung Kim wrote:
> Hi,
>
> Thanks for working on this!

Thanks for your review.
Just spotted comments for this version.
Sorry for delay.

>
> On Mon, Nov 16, 2020 at 03:12:47PM +0300, Alexey Budankov wrote:
>>
>> Changes in v3:
>> - avoided skipped redundant patch 3/15
>> - applied "data file" and "data directory" terms allover the patch set
>> - captured Acked-by: tags by Namhyung Kim
>> - avoided braces where don't needed
>> - employed thread local variable for serial trace streaming
>> - added specs for --thread option - core, socket, numa and user defined
>> - added parallel loading of data directory files similar to the prototype [1]
>
> Can you please consider splitting tracing records (FORK/MMAP/...) into
> a separate file? I think this change would put too much burden to the
> perf report side. I'm saying this repeatedly because I'm afraid that
> it'd be harder to change later once we accept this approach/format..

Alexey Bayduraev in To/Cc is going to proceed with this work
so there are chances to have updated version soon.

Thanks,
Alexei

\
 
 \ /
  Last update: 2020-12-15 16:08    [W:0.220 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site