Messages in this thread | | | Subject | Re: [PATCH -tip 23/32] sched: Add a per-thread core scheduling interface | From | chris hyser <> | Date | Tue, 15 Dec 2020 09:56:38 -0500 |
| |
On 12/14/20 6:25 PM, Joel Fernandes wrote: > On Mon, Dec 14, 2020 at 02:44:09PM -0500, chris hyser wrote: >> On 12/14/20 2:31 PM, Joel Fernandes wrote: >>>> diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c >>>> index cffdfab..50c31f3 100644 >>>> --- a/kernel/sched/debug.c >>>> +++ b/kernel/sched/debug.c >>>> @@ -1030,6 +1030,7 @@ void proc_sched_show_task(struct task_struct *p, struct pid_namespace *ns, >>>> #ifdef CONFIG_SCHED_CORE >>>> __PS("core_cookie", p->core_cookie); >>>> + __PS("core_task_cookie", p->core_task_cookie); >>>> #endif >>> >>> Hmm, so the final cookie of the task is always p->core_cookie. This is what >>> the scheduler uses. All other fields are ingredients to derive the final >>> cookie value. >>> >>> I will drop this hunk from your overall diff, but let me know if you >>> disagree! >> >> >> No problem. That was there primarily for debugging. > > Ok. I squashed Josh's changes into this patch and several of my fixups. So > there'll be 3 patches: > 1. CGroup + prctl (single patch as it is hell to split it) > 2. Documentation > 3. ksefltests > > Below is the diff of #1. I still have to squash in the stop_machine removal > and some more review changes. But other than that, please take a look and let > me know anything that's odd. I will test further as well.
Will do. Looking at it now and just started a build.
-chrish
| |