Messages in this thread | | | Date | Tue, 15 Dec 2020 12:37:10 +0100 | From | Maxime Ripard <> | Subject | Re: [PATCH] net: allwinner: Fix some resources leak in the error handling path of the probe and in the remove function |
| |
On Tue, Dec 15, 2020 at 12:11:53PM +0300, Dan Carpenter wrote: > On Tue, Dec 15, 2020 at 09:56:55AM +0100, Maxime Ripard wrote: > > Hi, > > > > On Mon, Dec 14, 2020 at 09:21:17PM +0100, Christophe JAILLET wrote: > > > 'irq_of_parse_and_map()' should be balanced by a corresponding > > > 'irq_dispose_mapping()' call. Otherwise, there is some resources leaks. > > > > Do you have a source to back that? It's not clear at all from the > > documentation for those functions, and couldn't find any user calling it > > from the ten-or-so random picks I took. > > It looks like irq_create_of_mapping() needs to be freed with > irq_dispose_mapping() so this is correct.
The doc should be updated first to make that clear then, otherwise we're going to fix one user while multiples will have poped up
Maxime [unhandled content-type:application/pgp-signature] | |