Messages in this thread | | | Subject | Re: [RFT][PATCH v1 0/3] ACPI: scan: Defer enumeration of devices with significant dependencies | From | Hans de Goede <> | Date | Tue, 15 Dec 2020 12:17:31 +0100 |
| |
Hi,
On 12/14/20 9:23 PM, Rafael J. Wysocki wrote: > Hi, > > This series addresses some enumeration ordering issues by using information > from _DEP to defer the enumeration of devices that are likely to depend on > operation region (OpRegion) handlers supplied by the drivers of other > devices. > > This allows the OpRegion suppliers to be probed and start working before the > devices depending on them are enumerated. > > Please see the patch changelogs for details. > > Hans, please test this series on the system with OpRegion dependencies in > control methods used for device enumeration.
Thank you for you work on this!
I started with reviewing the series so that I would know what to expect during testing. All 3 patches look good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
As is the series does not fix the Bluetooth HID misreporting on the system with OpRegion dependencies in its BT ACPI node's _HID, but ...
This is expected because that _HID has a _DEP on the GPO1 GPIO controller, which in turn has a _DEP pointing to the "Intel Baytrail Mailbox Device" ("INT33BD")
We (Linux) don't do anything with the INT33BD device, so it can simply be added to the acpi_ignore_dep_ids list. With this done the 3 patches from this RFT fix the BT _HID issue. IOW everything works as expected / as we want.
While at it I also booted the kernel with these patches on a Lenovo Yoga X1 Carbon 8th gen. I'm not seeing any adverse side effects there, so please add my tested-by to the entire series:
Tested-by: Hans de Goede <hdegoede@redhat.com>
I will send out a patch adding "INT33BD" to the acpi_ignore_dep_ids list (to be applied on top of this series) right away.
Regards,
Hans
| |