lkml.org 
[lkml]   [2020]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] sched: don't check rq after newidle_balance return positive
On Tue, Dec 15, 2020 at 02:48:50PM +0800, chenxg1x@gmail.com wrote:
> From: Chen Xiaoguang <xiaoggchen@tencent.com>
>
> In pick_next_task_fair, if CPU is going to idle newidle_balance
> is called first trying to pull some tasks.
> When newidle_balance returns positive which means it does
> pulls tasks or some tasks enqueued then there is no need to check
> sched_fair_runnable again.

No, I think it actually does need to, because while it counts the number
of tasks it pulled, it doesn't verify it still has them after it
re-acquires rq->lock. That is, someone could've come along and stolen
them right from under our noses.

>
> Signed-off-by: He Chen <heddchen@tencent.com>
> Signed-off-by: Xiaoguang Chen <xiaoggchen@tencent.com>

This SoB chain is broken. The first SoB should be the author, but From
does not match.

\
 
 \ /
  Last update: 2020-12-15 09:37    [W:0.035 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site