Messages in this thread | | | From | John Stultz <> | Date | Tue, 15 Dec 2020 16:33:45 -0800 | Subject | Re: [PATCH v7 2/5] dma-buf: heaps: Move heap-helper logic into the cma_heap implementation |
| |
On Tue, Dec 15, 2020 at 3:53 PM Guenter Roeck <linux@roeck-us.net> wrote: > > On Sat, Nov 21, 2020 at 11:49:59PM +0000, John Stultz wrote: > > Since the heap-helpers logic ended up not being as generic as > > hoped, move the heap-helpers dma_buf_ops implementations into > > the cma_heap directly. > > > > This will allow us to remove the heap_helpers code in a following > > patch. > > > > mips:allmodconfig: > > drivers/dma-buf/heaps/cma_heap.c: In function 'cma_heap_do_vmap': > drivers/dma-buf/heaps/cma_heap.c:195:10: error: implicit declaration of function 'vmap' >
Ah. Looks like we need to explicitly include linux/vmalloc.h.
Thanks for the report! I'll spin up a patch, validate it and send it out here shortly.
thanks -john
| |