Messages in this thread | | | Date | Wed, 16 Dec 2020 10:48:01 +1100 | From | Dave Chinner <> | Subject | Re: [v2 PATCH 6/9] mm: vmscan: use per memcg nr_deferred of shrinker |
| |
On Tue, Dec 15, 2020 at 02:27:18PM -0800, Yang Shi wrote: > On Mon, Dec 14, 2020 at 6:46 PM Dave Chinner <david@fromorbit.com> wrote: > > > > On Mon, Dec 14, 2020 at 02:37:19PM -0800, Yang Shi wrote: > > > Use per memcg's nr_deferred for memcg aware shrinkers. The shrinker's nr_deferred > > > will be used in the following cases: > > > 1. Non memcg aware shrinkers > > > 2. !CONFIG_MEMCG > > > 3. memcg is disabled by boot parameter > > > > > > Signed-off-by: Yang Shi <shy828301@gmail.com> > > > > Lots of lines way over 80 columns. > > I thought that has been lifted to 100 columns.
Documentation/process/coding-style.rst still says:
"The preferred limit on the length of a single line is 80 columns."
checkpatch might not warn about > 80 columns anymore, but if the file you are modifying is almost entirely 80 columns in width, then by default changes to that file should also stay within 80 columns.
I mostly consider using checkpatch to enforce coding styles to be harmful....
Cheers,
Dave. -- Dave Chinner david@fromorbit.com
| |