Messages in this thread | | | Date | Mon, 14 Dec 2020 22:14:34 +0100 | From | Vincent Stehlé <> | Subject | Re: [PATCH] net: korina: remove busy skb free |
| |
On Mon, Dec 14, 2020 at 11:03:12AM +0100, Julian Wiedmann wrote: > On 13.12.20 18:20, Vincent Stehlé wrote: ... > > @@ -216,7 +216,6 @@ static int korina_send_packet(struct sk_buff *skb, struct net_device *dev) > > netif_stop_queue(dev); > > else { > > dev->stats.tx_dropped++; > > - dev_kfree_skb_any(skb); > > spin_unlock_irqrestore(&lp->lock, flags); > > > > return NETDEV_TX_BUSY; > > > > As this skb is returned to the stack (and not dropped), the tx_dropped > statistics increment looks bogus too.
Hi Julian,
Thanks for the review. I will respin the patch to remove the statistics increment as well.
Best regards, Vincent.
| |