Messages in this thread | | | From | Rob Herring <> | Subject | Re: [PATCH v5] dt-bindings: usb: Add new compatible string for AM64 SoC | Date | Mon, 14 Dec 2020 14:21:04 -0600 |
| |
On Mon, 14 Dec 2020 19:31:09 +0530, Aswath Govindraju wrote: > Add compatible string in j721e-usb binding file as the same USB subsystem > is present in AM64. > > Signed-off-by: Aswath Govindraju <a-govindraju@ti.com> > --- > > Changes since v4: > - used oneOf instead of enum, as the schema has to convey that the strings > ti,j721e-usb and ti,am64-usb can be used combined or seperately in the > DT nodes. > > Changes since v3: > - used enum instead of anyOf. > > Changes since v2: > - added changes done over the versions. > > Changes since v1: > - replaced the '\t' at the beginning of the lines with spaces as it was > causing the dt_binding_check to fail. > > Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) >
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml: properties:compatible:oneOf:2:items: 'anyOf' conditional failed, one must be fixed: ['ti,j721e-usb', 'ti,am64-usb'] is not of type 'object', 'boolean' 'ti,j721e-usb' is not of type 'object', 'boolean' 'ti,am64-usb' is not of type 'object', 'boolean' /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml: ignoring, error in schema: properties: compatible: oneOf: 2: items warning: no schema found in file: ./Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
See https://patchwork.ozlabs.org/patch/1415942
This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit.
| |