lkml.org 
[lkml]   [2020]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 1/6] scsi: ufs: Remove stringize operator '#' restriction
From
Date
On Mon, 2020-12-14 at 08:46 -0800, Joe Perches wrote:
> > However, we have other cases, the symbol and enum name are not the
> > same,
> > we can redefine EM/EMe, but there will introduce some redundant
> > codes.
> > This patch is to remove this restriction, let others reuse the
> > current
> > EM/EMe definition.
>
> I think the other way (adding new definitions for the cases when the
> name and string are different) is less error prone.
>
yes, agree with you, but here it is ok, it is not too much copy/paste.

> > diff --git a/include/trace/events/ufs.h
> > b/include/trace/events/ufs.h
>
> []
> > +#define
> > UFS_LINK_STATES \
> > + EM(UIC_LINK_OFF_STATE, "UIC_LINK_OFF_STATE") \
> > + EM(UIC_LINK_ACTIVE_STATE, "UIC_LINK_ACTIVE_STATE,") \
>
> For instance:
>
> Like here where you added an unnecessary and unwanted comma

Thanks, I will fix it in next version.

Bean


\
 
 \ /
  Last update: 2020-12-14 19:55    [W:0.038 / U:0.512 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site