Messages in this thread | | | Date | Mon, 14 Dec 2020 16:32:55 +0100 | From | Thomas Bogendoerfer <> | Subject | Re: [PATCH 4/4] MIPS: mm: Clean up setup of protection map |
| |
On Sat, Dec 12, 2020 at 08:29:23AM -0800, Guenter Roeck wrote: > On Fri, Nov 13, 2020 at 12:09:52PM +0100, Thomas Bogendoerfer wrote: > > Protection map difference between RIXI and non RIXI cpus is _PAGE_NO_EXEC > > and _PAGE_NO_READ usage. Both already take care of cpu_has_rixi while > > setting up the page bits. So we just need one setup of protection map > > and can drop the now unused (and broken for RIXI) PAGE_* defines. > > > > Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de> > > --- > > This patch results in: > > drivers/video/fbdev/udlfb.c: In function 'dlfb_ops_mmap': > drivers/video/fbdev/udlfb.c:343:52: error: 'PAGE_SHARED' undeclared (first use in this function) > 343 | if (remap_pfn_range(vma, start, page, PAGE_SIZE, PAGE_SHARED)) > | ^~~~~~~~~~~ > > when building mips:allmodconfig.
thank you for the report, I've pushed a fix to mips-next.
Thomas.
-- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]
| |