Messages in this thread | | | Date | Mon, 14 Dec 2020 10:21:44 -0600 | From | Bjorn Andersson <> | Subject | Re: [PATCH -next] iommu: msm_iommu: Delete useless kfree code |
| |
On Mon 14 Dec 07:47 CST 2020, Zheng Yongjun wrote:
> The parameter of kfree function is NULL, so kfree code is useless, delete it. > > Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards, Bjorn
> --- > drivers/iommu/msm_iommu.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/iommu/msm_iommu.c b/drivers/iommu/msm_iommu.c > index 3615cd6241c4..1286674a1322 100644 > --- a/drivers/iommu/msm_iommu.c > +++ b/drivers/iommu/msm_iommu.c > @@ -319,7 +319,7 @@ static struct iommu_domain *msm_iommu_domain_alloc(unsigned type) > > priv = kzalloc(sizeof(*priv), GFP_KERNEL); > if (!priv) > - goto fail_nomem; > + return NULL; > > INIT_LIST_HEAD(&priv->list_attached); > > @@ -328,10 +328,6 @@ static struct iommu_domain *msm_iommu_domain_alloc(unsigned type) > priv->domain.geometry.force_aperture = true; > > return &priv->domain; > - > -fail_nomem: > - kfree(priv); > - return NULL; > } > > static void msm_iommu_domain_free(struct iommu_domain *domain) > -- > 2.22.0 >
| |