Messages in this thread Patch in this message | | | Date | Mon, 14 Dec 2020 17:16:44 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH v2 12/12] media: atomisp: Fix LOGICAL_CONTINUATIONS |
| |
On Mon, Dec 14, 2020 at 11:53:04AM +0000, David Laight wrote: > From: Philipp Gerlesberger > > Sent: 14 December 2020 11:02 > > > > Logical continuations should be on the previous line > > > > Co-developed-by: Andrey Khlopkov <ij72uhux@stud.informatik.uni-erlangen.de> > > Signed-off-by: Andrey Khlopkov <ij72uhux@stud.informatik.uni-erlangen.de> > > Signed-off-by: Philipp Gerlesberger <Philipp.Gerlesberger@fau.de> > > --- > > drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c > > b/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c > > index 2f1c2df59f71..7d44070c7114 100644 > > --- a/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c > > +++ b/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c > > @@ -24,8 +24,8 @@ > > *****************************************************************************/ > > int ia_css_queue_local_init(ia_css_queue_t *qhandle, ia_css_queue_local_t *desc) > > { > > - if (NULL == qhandle || NULL == desc > > - || NULL == desc->cb_elems || NULL == desc->cb_desc) { > > + if (NULL == qhandle || NULL == desc || > > + NULL == desc->cb_elems || NULL == desc->cb_desc) { > > /* Invalid parameters, return error*/
Delete this comment as well. It's pointless. (And the curly braces).
> > return -EINVAL; >
regards, dan carpenter
| |