Messages in this thread | | | Subject | Re: [PATCH][next] net: hns3: fix expression that is currently always true | From | Huazhong Tan <> | Date | Tue, 15 Dec 2020 09:34:45 +0800 |
| |
On 2020/12/15 8:00, Colin King wrote: > From: Colin Ian King<colin.king@canonical.com> > > The || condition in hdev->fd_active_type != HCLGE_FD_ARFS_ACTIVE || > hdev->fd_active_type != HCLGE_FD_RULE_NONE will always be true because > hdev->fd_active_type cannot be equal to two different values at the same > time. The expression is always true which is not correct. Fix this by > replacing || with && to correct the logic in the expression. > > Addresses-Coverity: ("Constant expression result") > Fixes: 0205ec041ec6 ("net: hns3: add support for hw tc offload of tc flower") > Signed-off-by: Colin Ian King<colin.king@canonical.com>
Reviewed-by: Huazhong Tan <tanhuazhong@huawei.com>
Thanks.
| |