Messages in this thread | | | Subject | Re: [PATCH v1] serial: 8250_fintek: Print Fintek chip name | From | "Ji-Ze Hong (Peter Hong)" <> | Date | Tue, 15 Dec 2020 08:29:41 +0800 |
| |
Hi,
Greg Kroah-Hartman 於 2020/12/14 下午 09:42 寫道: >> pdata->pid = chip; >> + >> + pr_info("%s%s%s Fintek %s\n", >> + uart->port.dev ? dev_name(uart->port.dev) : "", >> + uart->port.dev ? ": " : "", >> + uart->port.name, >> + chip_name); > > Drivers, if all goes well, should not print anything to the kernel log. > This isn't ok. > > And even if it was, dev_info() would be the correct thing to do...
Maybe can transform pr_info() to dev_dbg() for debug usage ?
-- With Best Regards, Peter Hong
| |