Messages in this thread | | | Date | Sun, 13 Dec 2020 19:30:02 +0200 | From | Eli Billauer <> | Subject | Re: [PATCH] char: xillybus: Add driver for XillyUSB (Xillybus variant for USB) |
| |
Hello Randy,
The new driver doesn't depend on XILLYBUS, so the patch puts it correctly outside the "if XILLYBUS" clause. It indeed looks like a mistake, but it isn't. :)
Thanks for paying attention to this.
Regards, Eli
On 13/12/20 19:22, Randy Dunlap wrote: > On 12/13/20 9:05 AM, eli.billauer@gmail.com wrote: > >> diff --git a/drivers/char/xillybus/Kconfig b/drivers/char/xillybus/Kconfig >> index 130dbdce858f..18fa99ec1029 100644 >> --- a/drivers/char/xillybus/Kconfig >> +++ b/drivers/char/xillybus/Kconfig >> @@ -32,3 +32,14 @@ config XILLYBUS_OF >> system, say M. >> >> endif # if XILLYBUS >> + >> > Hi Eli, > > You don't want this new part inside the "if XILLYBUS" block above? > IOW, XILLYUSB does not need XILLYBUS? > > >> +config XILLYUSB >> + tristate "XillyUSB: Xillybus generic FPGA interface for USB" >> + depends on USB >> + select CRC32 >> + help >> + XillyUSB is the Xillybus variant which uses USB for communicating >> + with the FPGA. >> + >> + Set to M if you want Xillybus to use USB for communicating with >> + the FPGA. >> > thanks. >
| |