Messages in this thread | | | Subject | Re: [PATCH v2 4/5] clk: qcom: clk-alpha-pll: Add support for Lucid 5LPE PLL | From | Stephen Boyd <> | Date | Thu, 10 Dec 2020 23:09:18 -0800 |
| |
Quoting Vinod Koul (2020-12-10 21:02:57) > On 10-12-20, 12:36, Stephen Boyd wrote: > > > + > > > + return regmap_update_bits(pll->clkr.regmap, PLL_USER_CTL(pll), > > > + (BIT(pll->width) - 1) << pll->post_div_shift, > > > > Use GENMASK? > > Looks like this can be: > GENMASK(pll->width + pll->post_div_shift - 1, pll->post_div_shift) > > Not sure which one you like :)
Preferably a local u32 mask = GENMASK(...)
| |