Messages in this thread | | | Date | Fri, 11 Dec 2020 10:33:21 -0500 | From | Richard Guy Briggs <> | Subject | Re: [PATCH -next] kernel/audit: convert comma to semicolon |
| |
On 2020-12-11 16:42, Zheng Yongjun wrote: > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com> > --- > kernel/audit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/audit.c b/kernel/audit.c > index 68cee3bc8cfe..c8497115be35 100644 > --- a/kernel/audit.c > +++ b/kernel/audit.c > @@ -2282,7 +2282,7 @@ static void audit_log_set_loginuid(kuid_t koldloginuid, kuid_t kloginuid, > > uid = from_kuid(&init_user_ns, task_uid(current)); > oldloginuid = from_kuid(&init_user_ns, koldloginuid); > - loginuid = from_kuid(&init_user_ns, kloginuid), > + loginuid = from_kuid(&init_user_ns, kloginuid);
Nice catch. That went unnoticed through 3 patches, the last two mine... Not quite sure why no compiler complained about it...
Reviewed-by: Richard Guy Briggs <rgb@redhat.com>
> tty = audit_get_tty(); > > audit_log_format(ab, "pid=%d uid=%u", task_tgid_nr(current), uid);
- RGB
-- Richard Guy Briggs <rgb@redhat.com> Sr. S/W Engineer, Kernel Security, Base Operating Systems Remote, Ottawa, Red Hat Canada IRC: rgb, SunRaycer Voice: +1.647.777.2635, Internal: (81) 32635
| |