lkml.org 
[lkml]   [2020]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [Intel-gfx] [patch 13/30] drm/i915/lpe_audio: Remove pointless irq_to_desc() usage
    Date
    On Thu, 10 Dec 2020, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
    > On Thu, Dec 10, 2020 at 08:25:49PM +0100, Thomas Gleixner wrote:
    >> Nothing uses the result and nothing should ever use it in driver code.
    >>
    >> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    >> Cc: Jani Nikula <jani.nikula@linux.intel.com>
    >> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
    >> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
    >> Cc: David Airlie <airlied@linux.ie>
    >> Cc: Daniel Vetter <daniel@ffwll.ch>
    >> Cc: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>
    >> Cc: Chris Wilson <chris@chris-wilson.co.uk>
    >> Cc: Wambui Karuga <wambui.karugax@gmail.com>
    >> Cc: intel-gfx@lists.freedesktop.org
    >> Cc: dri-devel@lists.freedesktop.org
    >
    > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

    Thomas, I presume you want to merge this series as a whole.

    Acked-by: Jani Nikula <jani.nikula@intel.com>

    for merging via whichever tree makes most sense. Please let us know if
    you want us to pick this up via drm-intel instead.

    >
    >> ---
    >> drivers/gpu/drm/i915/display/intel_lpe_audio.c | 4 ----
    >> 1 file changed, 4 deletions(-)
    >>
    >> --- a/drivers/gpu/drm/i915/display/intel_lpe_audio.c
    >> +++ b/drivers/gpu/drm/i915/display/intel_lpe_audio.c
    >> @@ -297,13 +297,9 @@ int intel_lpe_audio_init(struct drm_i915
    >> */
    >> void intel_lpe_audio_teardown(struct drm_i915_private *dev_priv)
    >> {
    >> - struct irq_desc *desc;
    >> -
    >> if (!HAS_LPE_AUDIO(dev_priv))
    >> return;
    >>
    >> - desc = irq_to_desc(dev_priv->lpe_audio.irq);
    >> -
    >> lpe_audio_platdev_destroy(dev_priv);
    >>
    >> irq_free_desc(dev_priv->lpe_audio.irq);
    >>
    >> _______________________________________________
    >> Intel-gfx mailing list
    >> Intel-gfx@lists.freedesktop.org
    >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

    --
    Jani Nikula, Intel Open Source Graphics Center

    \
     
     \ /
      Last update: 2020-12-11 10:56    [W:3.425 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site