lkml.org 
[lkml]   [2020]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] gpio: aspeed: Lock GPIO pin used as IRQ
On Thu, Dec 10, 2020 at 9:36 AM Troy Lee <troy_lee@aspeedtech.com> wrote:
>
> GPIO pins can be used as IRQ indicators. When they do,
> those pins should be flaged with locks to avoid kernel

flagged

> warning message.

...

> @@ -651,6 +651,13 @@ static int aspeed_gpio_set_type(struct irq_data *d, unsigned int type)

> + rc = gpiochip_lock_as_irq(&gpio->chip, d->hwirq);
> + if (rc) {
> + dev_err(gpio->chip.parent, "unable to lock GPIO %lu as IRQ\n",
> + d->hwirq);
> + return rc;
> + }

It's a copy'n'paste of generic code. Why do you need it in an unusual
place, i.e. ->irq_set_type() IIUC?
Can you elaborate about an issue, because this seems to be a hack?

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2020-12-10 15:16    [W:3.993 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site