lkml.org 
[lkml]   [2020]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 1/5] drm/bridge: nwl-dsi: Set PHY mode in nwl_dsi_enable()
    Date
    The Northwest Logic MIPI DSI host controller embedded in i.MX8qxp
    works with a Mixel MIPI DPHY + LVDS PHY combo to support either
    a MIPI DSI display or a LVDS display. So, this patch calls
    phy_set_mode() from nwl_dsi_enable() to set PHY mode to MIPI DPHY
    explicitly.

    Cc: Guido Günther <agx@sigxcpu.org>
    Cc: Robert Chiras <robert.chiras@nxp.com>
    Cc: Martin Kepplinger <martin.kepplinger@puri.sm>
    Cc: Andrzej Hajda <a.hajda@samsung.com>
    Cc: Neil Armstrong <narmstrong@baylibre.com>
    Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
    Cc: Jonas Karlman <jonas@kwiboo.se>
    Cc: Jernej Skrabec <jernej.skrabec@siol.net>
    Cc: David Airlie <airlied@linux.ie>
    Cc: Daniel Vetter <daniel@ffwll.ch>
    Cc: NXP Linux Team <linux-imx@nxp.com>
    Reviewed-by: Guido Günther <agx@sigxcpu.org>
    Signed-off-by: Liu Ying <victor.liu@nxp.com>
    ---
    v2->v3:
    * No change.

    v1->v2:
    * Add Guido's R-b tag.

    drivers/gpu/drm/bridge/nwl-dsi.c | 6 ++++++
    1 file changed, 6 insertions(+)

    diff --git a/drivers/gpu/drm/bridge/nwl-dsi.c b/drivers/gpu/drm/bridge/nwl-dsi.c
    index 66b6740..be6bfc5 100644
    --- a/drivers/gpu/drm/bridge/nwl-dsi.c
    +++ b/drivers/gpu/drm/bridge/nwl-dsi.c
    @@ -678,6 +678,12 @@ static int nwl_dsi_enable(struct nwl_dsi *dsi)
    return ret;
    }

    + ret = phy_set_mode(dsi->phy, PHY_MODE_MIPI_DPHY);
    + if (ret < 0) {
    + DRM_DEV_ERROR(dev, "Failed to set DSI phy mode: %d\n", ret);
    + goto uninit_phy;
    + }
    +
    ret = phy_configure(dsi->phy, phy_cfg);
    if (ret < 0) {
    DRM_DEV_ERROR(dev, "Failed to configure DSI phy: %d\n", ret);
    --
    2.7.4
    \
     
     \ /
      Last update: 2020-12-11 02:58    [W:3.531 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site