lkml.org 
[lkml]   [2020]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC PATCH 1/1] platform-msi: Add platform check for subdevice irq domain
From
Date
On Thu, 2020-12-10 at 12:57 -0600, Bjorn Helgaas wrote:
> What is the point of a function called probably_on_bare_metal()?
> *Probably*? The caller can't really do anything with the fact that
> we're not 100% sure this gives the correct answer. Just call it
> "on_bare_metal()" or something and accept the fact that it might be
> wrong sometimes.

Acknowledging that it's a heuristic is OK, but we should certainly be
clear about whether it has false positives, false negatives, or both.
[unhandled content-type:application/x-pkcs7-signature]
\
 
 \ /
  Last update: 2020-12-10 20:19    [W:0.556 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site