Messages in this thread | | | Subject | Re: [PATCH -next v2] firmware: xilinx: Mark pm_api_features_map with static keyword | From | Michal Simek <> | Date | Tue, 1 Dec 2020 13:03:59 +0100 |
| |
On 01. 12. 20 12:51, Zou Wei wrote: > Fix the following sparse warning: > > drivers/firmware/xilinx/zynqmp.c:32:1: warning: symbol 'pm_api_features_map' was not declared. Should it be static? > > Signed-off-by: Zou Wei <zou_wei@huawei.com> > --- > drivers/firmware/xilinx/zynqmp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c > index d08ac82..fd95ede 100644 > --- a/drivers/firmware/xilinx/zynqmp.c > +++ b/drivers/firmware/xilinx/zynqmp.c > @@ -29,7 +29,7 @@ > #define PM_API_FEATURE_CHECK_MAX_ORDER 7 > > static bool feature_check_enabled; > -DEFINE_HASHTABLE(pm_api_features_map, PM_API_FEATURE_CHECK_MAX_ORDER); > +static DEFINE_HASHTABLE(pm_api_features_map, PM_API_FEATURE_CHECK_MAX_ORDER); > > /** > * struct pm_api_feature_data - PM API Feature data >
The patch is good but I am missing fixed tag to get it to LTS. When you add it please add my Reviewed-by: Michal Simek <michal.simek@xilinx.com>
Thanks, Michal
| |