Messages in this thread | | | Date | Tue, 1 Dec 2020 12:22:15 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH v2 2/4] configfs: use BIT() for internal flags |
| |
On Mon, Nov 30, 2020 at 05:47:02PM +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > For better readability and maintenance: use the BIT() macro for flag > definitions.
This does not improve readability, as I now need to look up a macro, one that doesn't make any sense at all. If you really prefer bit based numbering just use the totally obvious (1 << bit) syntax.
| |