Messages in this thread | | | Subject | Re: [PATCH 1/5] tty: add port flag to suppress ready signalling on open | From | Jiri Slaby <> | Date | Tue, 1 Dec 2020 08:16:04 +0100 |
| |
On 01. 12. 20, 8:09, Mychaela Falconia wrote: > On 11/30/20, Jiri Slaby <jirislaby@kernel.org> wrote: >> port can be const here. >> [...] >> We have assign_bit() for these cases these days. > > Johan's patch adding test and set accessor inline functions for the > new flag follows the style of the existing accessor inline functions > for previously existing flags, for the sake of consistency. If we are > going to use the new style (const for test functions, assign_bit() for > set functions) for the new flag, then we should also change all > existing ones for consistency. In terms of patch splitting, would it > be most kosher to have one patch that updates the style of existing > accessor inline functions, and then the interesting patch that adds > the new flag?
Yes. Or the other way around. Add this new using const+assign_bit and convert the rest on the top of the series.
thanks, -- js
| |