lkml.org 
[lkml]   [2020]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 06/98] btrfs: tree-checker: add missing returns after data_ref alignment checks
    Date
    From: David Sterba <dsterba@suse.com>

    commit 6d06b0ad94d3dd7e3503d8ad39c39c4634884611 upstream.

    There are sectorsize alignment checks that are reported but then
    check_extent_data_ref continues. This was not intended, wrong alignment
    is not a minor problem and we should return with error.

    CC: stable@vger.kernel.org # 5.4+
    Fixes: 0785a9aacf9d ("btrfs: tree-checker: Add EXTENT_DATA_REF check")
    Reviewed-by: Qu Wenruo <wqu@suse.com>
    Signed-off-by: David Sterba <dsterba@suse.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/btrfs/tree-checker.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/fs/btrfs/tree-checker.c
    +++ b/fs/btrfs/tree-checker.c
    @@ -1269,6 +1269,7 @@ static int check_extent_data_ref(struct
    "invalid item size, have %u expect aligned to %zu for key type %u",
    btrfs_item_size_nr(leaf, slot),
    sizeof(*dref), key->type);
    + return -EUCLEAN;
    }
    if (!IS_ALIGNED(key->objectid, leaf->fs_info->sectorsize)) {
    generic_err(leaf, slot,
    @@ -1297,6 +1298,7 @@ static int check_extent_data_ref(struct
    extent_err(leaf, slot,
    "invalid extent data backref offset, have %llu expect aligned to %u",
    offset, leaf->fs_info->sectorsize);
    + return -EUCLEAN;
    }
    }
    return 0;

    \
     
     \ /
      Last update: 2020-12-01 10:08    [W:4.047 / U:0.324 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site