Messages in this thread | | | Date | Tue, 1 Dec 2020 19:06:45 -0600 | From | Bjorn Andersson <> | Subject | Re: [PATCH v2 2/2] arm64: dts: qcom: db845c: Enable gpi_dma0 node |
| |
On Mon 30 Nov 22:25 CST 2020, Vinod Koul wrote:
> gpi_dma0 can be used for spi and i2c transfers on db845c, so enable it > > Signed-off-by: Vinod Koul <vkoul@kernel.org> > --- > arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > index 7cc236575ee2..0653468f26ce 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > @@ -418,6 +418,10 @@ &gcc { > <GCC_QSPI_CNOC_PERIPH_AHB_CLK>; > }; > > +&gpi_dma0 { > + status = "okay"; > +}; > +
But you're only enabling the gpi, you don't have anything wired to it, so why enable it?
I took a look downstream and they have all the i2c and spi nodes with their dmas filled out - and the two gpis enabled at all times (sdm845.dtsi). Can/should we do the same?
Regards, Bjorn
> &gpu { > zap-shader { > memory-region = <&gpu_mem>; > -- > 2.26.2 >
| |