Messages in this thread | | | Subject | Re: [PATCH 05/18] software_node: Alter software_node_unregister_nodes() to unregister the array in reverse order | From | Dan Scally <> | Date | Tue, 1 Dec 2020 23:36:48 +0000 |
| |
Hi Andy
On 30/11/2020 17:45, Andy Shevchenko wrote: > On Mon, Nov 30, 2020 at 01:31:16PM +0000, Daniel Scally wrote: >> Software nodes that are children of another software node should be >> unregistered before their parent. To allow easy unregistering of an array >> of software_nodes ordered parent to child, reverse the order in which >> this function unregisters software_nodes. > > Should be folded in the previous patch. Otherwise we will have a history point > where register() behaves differently to unregister().
OK sure, I'll squash them - and thanks for your comments on the previous patch, I condensed the conditionals as you suggest
> ... > >> + * @nodes: Zero terminated array of software nodes to be unregistered. If >> + * parent pointers are set up in any of the software nodes then the array >> + * MUST be ordered such that parents come before their children. > > Please, leave field description short. Rather add another note to the > Description below.
Ack
| |