lkml.org 
[lkml]   [2020]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 net-next 1/4] dt-bindings: net: nfc: s3fwrn5: Support a UART interface
    On Tue, Dec 01, 2020 at 10:50:25PM +0900, Bongsu Jeon wrote:
    > From: Bongsu Jeon <bongsu.jeon@samsung.com>
    >
    > Since S3FWRN82 NFC Chip, The UART interface can be used.
    > S3FWRN82 supports I2C and UART interface.
    >
    > Signed-off-by: Bongsu Jeon <bongsu.jeon@samsung.com>
    > ---
    > .../bindings/net/nfc/samsung,s3fwrn5.yaml | 32 ++++++++++++++++++++--
    > 1 file changed, 29 insertions(+), 3 deletions(-)
    >
    > diff --git a/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml b/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml
    > index cb0b8a5..cc5f9a1 100644
    > --- a/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml
    > +++ b/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml
    > @@ -12,7 +12,10 @@ maintainers:
    >
    > properties:
    > compatible:
    > - const: samsung,s3fwrn5-i2c
    > + items:

    This still has items but it should be a simple enum.

    > + - enum:
    > + - samsung,s3fwrn5-i2c
    > + - samsung,s3fwrn82
    >
    > en-gpios:
    > maxItems: 1
    > @@ -47,10 +50,19 @@ additionalProperties: false
    > required:
    > - compatible
    > - en-gpios
    > - - interrupts
    > - - reg
    > - wake-gpios
    >
    > +allOf:
    > + - if:
    > + properties:
    > + compatible:
    > + contains:
    > + const: samsung,s3fwrn5-i2c
    > + then:
    > + required:
    > + - interrupts
    > + - reg
    > +
    > examples:
    > - |
    > #include <dt-bindings/gpio/gpio.h>
    > @@ -71,3 +83,17 @@ examples:
    > wake-gpios = <&gpj0 2 GPIO_ACTIVE_HIGH>;
    > };
    > };
    > + # UART example on Raspberry Pi
    > + - |
    > + uart0 {
    > + status = "okay";
    > +
    > + nfc {
    > + compatible = "samsung,s3fwrn82";
    > +
    > + en-gpios = <&gpio 20 0>;
    > + wake-gpios = <&gpio 16 0>;

    Use GPIO flags like in example above.

    Best regards,
    Krzysztof

    \
     
     \ /
      Last update: 2020-12-01 21:09    [W:3.660 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site