Messages in this thread Patch in this message | | | Date | Tue, 1 Dec 2020 15:03:01 +0100 | From | Mauro Carvalho Chehab <> | Subject | Re: [PATCH v5 07/16] completion: drop init_completion define |
| |
Em Tue, 1 Dec 2020 13:54:45 +0100 Peter Zijlstra <peterz@infradead.org> escreveu:
> On Tue, Dec 01, 2020 at 01:09:00PM +0100, Mauro Carvalho Chehab wrote: > > Changeset cd8084f91c02 ("locking/lockdep: Apply crossrelease to completions") > > added a CONFIG_LOCKDEP_COMPLETE (that was later renamed to > > CONFIG_LOCKDEP_COMPLETIONS). > > > > Such changeset renamed the init_completion, and add a macro > > that would either run a modified version or the original code. > > > > However, such code reported too many false positives. So, it > > ended being dropped later on by > > changeset e966eaeeb623 ("locking/lockdep: Remove the cross-release locking checks"). > > > > Yet, the define remained there as just: > > > > #define init_completion(x) __init_completion(x) > > > > Get rid of the define, and return __init_completion() function > > to its original name. > > > > Fixes: e966eaeeb623 ("locking/lockdep: Remove the cross-release locking checks") > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> > > --- > > Your patch is weird, did you add -C 1000 or something?
Per a past review request, I used -U32 on this particular series, in order to be able to display the function name and the kernel-doc markup at the same time.
I'm enclosing the patch with -U3.
Thanks, Mauro
[PATCH] completion: drop init_completion define
Changeset cd8084f91c02 ("locking/lockdep: Apply crossrelease to completions") added a CONFIG_LOCKDEP_COMPLETE (that was later renamed to CONFIG_LOCKDEP_COMPLETIONS).
Such changeset renamed the init_completion, and add a macro that would either run a modified version or the original code.
However, such code reported too many false positives. So, it ended being dropped later on by changeset e966eaeeb623 ("locking/lockdep: Remove the cross-release locking checks").
Yet, the define remained there as just:
#define init_completion(x) __init_completion(x)
Get rid of the define, and return __init_completion() function to its original name.
Fixes: e966eaeeb623 ("locking/lockdep: Remove the cross-release locking checks")
diff --git a/include/linux/completion.h b/include/linux/completion.h index bf8e77001f18..51d9ab079629 100644 --- a/include/linux/completion.h +++ b/include/linux/completion.h @@ -28,8 +28,7 @@ struct completion { struct swait_queue_head wait; }; -#define init_completion_map(x, m) __init_completion(x) -#define init_completion(x) __init_completion(x) +#define init_completion_map(x, m) init_completion(x) static inline void complete_acquire(struct completion *x) {} static inline void complete_release(struct completion *x) {} @@ -82,7 +81,7 @@ static inline void complete_release(struct completion *x) {} * This inline function will initialize a dynamically created completion * structure. */ -static inline void __init_completion(struct completion *x) +static inline void init_completion(struct completion *x) { x->done = 0; init_swait_queue_head(&x->wait);
| |