lkml.org 
[lkml]   [2020]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 05/23] arm64: Extract parts of el2_setup into a macro
    Hey Mark,

    > In the head.S code, this was under an ifdef CONFIG_ARM_GIC_V3, but that
    > ifdef wasn't carried into the macro here, or into its use below. I'm not
    > sure of the impact, but that does seem to be a functional change.
    >
    > > +
    > > +.macro __init_el2_hstr
    > > + msr hstr_el2, xzr // Disable CP15 traps to EL2
    > > +.endm
    >
    > Likewise, this used to be be guarded by CONFIG_COMPAT, but that's not
    > carried into the macro or its use.
    >
    > If the intent was to remove the conditionality, then that should be
    > mentioned in the commit message, since it is a potential functional
    > change.

    Apologies, and well spotted. Marc suggested removing the ifdefs as redundant
    during his review of v2. I'll update the commit message to reflect that.

    David

    \
     
     \ /
      Last update: 2020-12-01 14:58    [W:4.122 / U:0.208 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site