lkml.org 
[lkml]   [2020]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 50/86] ceph: promote to unsigned long long before shifting
    Date
    From: Matthew Wilcox (Oracle) <willy@infradead.org>

    commit c403c3a2fbe24d4ed33e10cabad048583ebd4edf upstream.

    On 32-bit systems, this shift will overflow for files larger than 4GB.

    Cc: stable@vger.kernel.org
    Fixes: 61f68816211e ("ceph: check caps in filemap_fault and page_mkwrite")
    Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
    Reviewed-by: Jeff Layton <jlayton@kernel.org>
    Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/ceph/addr.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/fs/ceph/addr.c
    +++ b/fs/ceph/addr.c
    @@ -1243,7 +1243,7 @@ static int ceph_filemap_fault(struct vm_
    struct ceph_inode_info *ci = ceph_inode(inode);
    struct ceph_file_info *fi = vma->vm_file->private_data;
    struct page *pinned_page = NULL;
    - loff_t off = vmf->pgoff << PAGE_CACHE_SHIFT;
    + loff_t off = (loff_t)vmf->pgoff << PAGE_CACHE_SHIFT;
    int want, got, ret;

    dout("filemap_fault %p %llx.%llx %llu~%zd trying to get caps\n",

    \
     
     \ /
      Last update: 2020-11-09 14:44    [W:4.177 / U:0.624 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site