lkml.org 
[lkml]   [2020]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.9 099/133] drm/vc4: drv: Add error handding for bind
    Date
    From: Hoegeun Kwon <hoegeun.kwon@samsung.com>

    [ Upstream commit 9ce0af3e9573fb84c4c807183d13ea2a68271e4b ]

    There is a problem that if vc4_drm bind fails, a memory leak occurs on
    the drm_property_create side. Add error handding for drm_mode_config.

    Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
    Signed-off-by: Maxime Ripard <maxime@cerno.tech>
    Link: https://patchwork.freedesktop.org/patch/msgid/20201027041442.30352-2-hoegeun.kwon@samsung.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/vc4/vc4_drv.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c
    index 38343d2fb4fb4..f6995e7f6eb6e 100644
    --- a/drivers/gpu/drm/vc4/vc4_drv.c
    +++ b/drivers/gpu/drm/vc4/vc4_drv.c
    @@ -310,6 +310,7 @@ static int vc4_drm_bind(struct device *dev)
    component_unbind_all(dev, drm);
    gem_destroy:
    vc4_gem_destroy(drm);
    + drm_mode_config_cleanup(drm);
    vc4_bo_cache_destroy(drm);
    dev_put:
    drm_dev_put(drm);
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-11-09 14:22    [W:4.023 / U:0.376 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site