lkml.org 
[lkml]   [2020]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.9 019/133] drm/i915: Restore ILK-M RPS support
    Date
    From: Ville Syrjälä <ville.syrjala@linux.intel.com>

    commit 5cbd7685b22823ebf432ec71eac1691b71c41037 upstream.

    Restore RPS for ILK-M. We lost it when an extra HAS_RPS()
    check appeared in intel_rps_enable().

    Unfortunaltey this just makes the performance worse on my
    ILK because intel_ips insists on limiting the GPU freq to
    the minimum. If we don't do the RPS init then intel_ips will
    not limit the frequency for whatever reason. Either it can't
    get at some required information and thus makes wrong decisions,
    or we mess up some weights/etc. and cause it to make the wrong
    decisions when RPS init has been done, or the entire thing is
    just wrong. Would require a bunch of reverse engineering to
    figure out what's going on.

    Cc: stable@vger.kernel.org
    Cc: Chris Wilson <chris@chris-wilson.co.uk>
    Fixes: 9c878557b1eb ("drm/i915/gt: Use the RPM config register to determine clk frequencies")
    Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20201021131443.25616-1-ville.syrjala@linux.intel.com
    Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
    (cherry picked from commit 2bf06370bcfb0dea5655e9a5ad460c7f7dca7739)
    Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/gpu/drm/i915/i915_pci.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/gpu/drm/i915/i915_pci.c
    +++ b/drivers/gpu/drm/i915/i915_pci.c
    @@ -389,6 +389,7 @@ static const struct intel_device_info il
    GEN5_FEATURES,
    PLATFORM(INTEL_IRONLAKE),
    .is_mobile = 1,
    + .has_rps = true,
    .display.has_fbc = 1,
    };


    \
     
     \ /
      Last update: 2020-11-09 14:16    [W:2.113 / U:0.220 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site