lkml.org 
[lkml]   [2020]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 49/71] blk-cgroup: Fix memleak on error path
    Date
    From: Gabriel Krisman Bertazi <krisman@collabora.com>

    [ Upstream commit 52abfcbd57eefdd54737fc8c2dc79d8f46d4a3e5 ]

    If new_blkg allocation raced with blk_policy change and
    blkg_lookup_check fails, new_blkg is leaked.

    Acked-by: Tejun Heo <tj@kernel.org>
    Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>
    Signed-off-by: Jens Axboe <axboe@kernel.dk>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    block/blk-cgroup.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c
    index a06547fe6f6b4..51fc803c999d7 100644
    --- a/block/blk-cgroup.c
    +++ b/block/blk-cgroup.c
    @@ -882,6 +882,7 @@ int blkg_conf_prep(struct blkcg *blkcg, const struct blkcg_policy *pol,
    blkg = blkg_lookup_check(pos, pol, q);
    if (IS_ERR(blkg)) {
    ret = PTR_ERR(blkg);
    + blkg_free(new_blkg);
    goto fail_unlock;
    }

    --
    2.27.0


    \
     
     \ /
      Last update: 2020-11-09 14:10    [W:2.356 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site