Messages in this thread | | | Subject | Re: [PATCH v2] mm/gup_test: GUP_TEST depends on DEBUG_FS | From | Randy Dunlap <> | Date | Sun, 8 Nov 2020 23:52:14 -0800 |
| |
On 11/8/20 11:45 PM, John Hubbard wrote: > On 11/8/20 12:37 AM, Barry Song wrote: >> Without DEBUG_FS, all the code in gup_test becomes meaningless. For sure >> kernel provides debugfs stub while DEBUG_FS is disabled, but the point >> here is that GUP_TEST can do nothing without DEBUG_FS. >> >> Cc: John Hubbard <jhubbard@nvidia.com> >> Cc: Ralph Campbell <rcampbell@nvidia.com> >> Cc: Randy Dunlap <rdunlap@infradead.org> >> Suggested-by: John Garry <john.garry@huawei.com> >> Signed-off-by: Barry Song <song.bao.hua@hisilicon.com> >> --- >> -v2: >> add comment as a prompt to users as commented by John and Randy, thanks! >> >> mm/Kconfig | 4 ++++ >> 1 file changed, 4 insertions(+) > > Thanks for suffering through a lot of discussion about this! > > Reviewed-by: John Hubbard <jhubbard@nvidia.com> > > > thanks,
Acked-by: Randy Dunlap <rdunlap@infradead.org>
thanks.
-- ~Randy
| |