lkml.org 
[lkml]   [2020]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4] dmaengine: qcom: Add ADM driver
    HI Jonathan,

    On 23-09-20, 20:40, Jonathan McDowell wrote:
    > Add the DMA engine driver for the QCOM Application Data Mover (ADM) DMA
    > controller found in the MSM8x60 and IPQ/APQ8064 platforms.

    Mostly it looks good, some nitpicks

    > The ADM supports both memory to memory transactions and memory
    > to/from peripheral device transactions. The controller also provides
    > flow control capabilities for transactions to/from peripheral devices.
    >
    > The initial release of this driver supports slave transfers to/from
    > peripherals and also incorporates CRCI (client rate control interface)
    > flow control.

    Can you also convert the binding from txt to yaml?

    > diff --git a/drivers/dma/qcom/Kconfig b/drivers/dma/qcom/Kconfig
    > index 3bcb689162c6..0389d60d2604 100644
    > --- a/drivers/dma/qcom/Kconfig
    > +++ b/drivers/dma/qcom/Kconfig
    > @@ -1,4 +1,15 @@
    > # SPDX-License-Identifier: GPL-2.0-only
    > +config QCOM_ADM
    > + tristate "Qualcomm ADM support"
    > + depends on (ARCH_QCOM || COMPILE_TEST) && !PHYS_ADDR_T_64BIT

    why !PHYS_ADDR_T_64BIT ..?

    > + select DMA_ENGINE
    > + select DMA_VIRTUAL_CHANNELS
    > + help
    > + Enable support for the Qualcomm Application Data Mover (ADM) DMA
    > + controller, as present on MSM8x60, APQ8064, and IPQ8064 devices.
    > + This controller provides DMA capabilities for both general purpose
    > + and on-chip peripheral devices.

    > +static const struct of_device_id adm_of_match[] = {
    > + { .compatible = "qcom,adm", },

    I know we have merged the binding, but should we not have a soc specific
    compatible?

    --
    ~Vinod

    \
     
     \ /
      Last update: 2020-11-09 12:42    [W:2.283 / U:0.404 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site