lkml.org 
[lkml]   [2020]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.9 39/55] vfio: platform: fix reference leak in vfio_platform_open
    Date
    From: Zhang Qilong <zhangqilong3@huawei.com>

    [ Upstream commit bb742ad01961a3b9d1f9d19375487b879668b6b2 ]

    pm_runtime_get_sync() will increment pm usage counter even it
    failed. Forgetting to call pm_runtime_put will result in
    reference leak in vfio_platform_open, so we should fix it.

    Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
    Acked-by: Eric Auger <eric.auger@redhat.com>
    Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/vfio/platform/vfio_platform_common.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/vfio/platform/vfio_platform_common.c b/drivers/vfio/platform/vfio_platform_common.c
    index c0771a9567fb5..fb4b385191f28 100644
    --- a/drivers/vfio/platform/vfio_platform_common.c
    +++ b/drivers/vfio/platform/vfio_platform_common.c
    @@ -267,7 +267,7 @@ static int vfio_platform_open(void *device_data)

    ret = pm_runtime_get_sync(vdev->device);
    if (ret < 0)
    - goto err_pm;
    + goto err_rst;

    ret = vfio_platform_call_reset(vdev, &extra_dbg);
    if (ret && vdev->reset_required) {
    @@ -284,7 +284,6 @@ static int vfio_platform_open(void *device_data)

    err_rst:
    pm_runtime_put(vdev->device);
    -err_pm:
    vfio_platform_irq_cleanup(vdev);
    err_irq:
    vfio_platform_regions_cleanup(vdev);
    --
    2.27.0
    \
     
     \ /
      Last update: 2020-11-10 05:05    [W:4.027 / U:0.276 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site