lkml.org 
[lkml]   [2020]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.4 16/42] drm/amd/pm: do not use ixFEATURE_STATUS for checking smc running
    Date
    From: Evan Quan <evan.quan@amd.com>

    [ Upstream commit 786436b453001dafe81025389f96bf9dac1e9690 ]

    This reverts commit f87812284172a9809820d10143b573d833cd3f75 ("drm/amdgpu:
    Fix bug where DPM is not enabled after hibernate and resume").
    It was intended to fix Hawaii S4(hibernation) issue but break S3. As
    ixFEATURE_STATUS is filled with garbage data on resume which can be
    only cleared by reloading smc firmware(but that will involve many
    changes). So, we will revert this S4 fix and seek a new way.

    Signed-off-by: Evan Quan <evan.quan@amd.com>
    Tested-by: Sandeep Raghuraman <sandy.8925@gmail.com>
    Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/amd/powerplay/smumgr/ci_smumgr.c | 5 +----
    1 file changed, 1 insertion(+), 4 deletions(-)

    diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/ci_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/ci_smumgr.c
    index 0f4f27a89020d..42c8f8731a504 100644
    --- a/drivers/gpu/drm/amd/powerplay/smumgr/ci_smumgr.c
    +++ b/drivers/gpu/drm/amd/powerplay/smumgr/ci_smumgr.c
    @@ -2725,10 +2725,7 @@ static int ci_initialize_mc_reg_table(struct pp_hwmgr *hwmgr)

    static bool ci_is_dpm_running(struct pp_hwmgr *hwmgr)
    {
    - return (1 == PHM_READ_INDIRECT_FIELD(hwmgr->device,
    - CGS_IND_REG__SMC, FEATURE_STATUS,
    - VOLTAGE_CONTROLLER_ON))
    - ? true : false;
    + return ci_is_smc_ram_running(hwmgr);
    }

    static int ci_smu_init(struct pp_hwmgr *hwmgr)
    --
    2.27.0
    \
     
     \ /
      Last update: 2020-11-10 05:02    [W:4.436 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site