lkml.org 
[lkml]   [2020]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.19 04/21] gfs2: Add missing truncate_inode_pages_final for sd_aspace
    Date
    From: Bob Peterson <rpeterso@redhat.com>

    [ Upstream commit a9dd945ccef07a904e412f208f8de708a3d7159e ]

    Gfs2 creates an address space for its rgrps called sd_aspace, but it never
    called truncate_inode_pages_final on it. This confused vfs greatly which
    tried to reference the address space after gfs2 had freed the superblock
    that contained it.

    This patch adds a call to truncate_inode_pages_final for sd_aspace, thus
    avoiding the use-after-free.

    Signed-off-by: Bob Peterson <rpeterso@redhat.com>
    Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/gfs2/super.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c
    index a971862b186e3..22cd68bd8c9b0 100644
    --- a/fs/gfs2/super.c
    +++ b/fs/gfs2/super.c
    @@ -934,6 +934,7 @@ static void gfs2_put_super(struct super_block *sb)
    gfs2_jindex_free(sdp);
    /* Take apart glock structures and buffer lists */
    gfs2_gl_hash_clear(sdp);
    + truncate_inode_pages_final(&sdp->sd_aspace);
    gfs2_delete_debugfs_file(sdp);
    /* Unmount the locking protocol */
    gfs2_lm_unmount(sdp);
    --
    2.27.0
    \
     
     \ /
      Last update: 2020-11-10 05:01    [W:3.858 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site