Messages in this thread | | | Subject | Re: [PATCH v1 3/3] vt: keyboard, make use of assign_bit() API | From | Jiri Slaby <> | Date | Mon, 9 Nov 2020 10:58:53 +0100 |
| |
On 06. 11. 20, 15:35, Andy Shevchenko wrote: > We have for some time the assign_bit() API to replace open coded > > if (foo) > set_bit(n, bar); > else > clear_bit(n, bar); > > Use this API in VT keyboard library code. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Jiri Slaby <jirislaby@kernel.org>
> --- > drivers/tty/vt/keyboard.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/tty/vt/keyboard.c b/drivers/tty/vt/keyboard.c > index 647c343f61fb..b5132191b0ad 100644 > --- a/drivers/tty/vt/keyboard.c > +++ b/drivers/tty/vt/keyboard.c > @@ -1433,10 +1433,7 @@ static void kbd_keycode(unsigned int keycode, int down, bool hw_raw) > raw_mode = true; > } > > - if (down) > - set_bit(keycode, key_down); > - else > - clear_bit(keycode, key_down); > + assign_bit(keycode, key_down, down); > > if (rep && > (!vc_kbd_mode(kbd, VC_REPEAT) || >
-- js suse labs
| |