lkml.org 
[lkml]   [2020]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v5 1/4] HID: i2c-hid: Reorganize so ACPI and OF are separate modules
    Hi,

    On Mon, Nov 9, 2020 at 1:37 PM Douglas Anderson <dianders@chromium.org> wrote:
    >
    > +int i2c_hid_acpi_probe(struct i2c_client *client,
    > + const struct i2c_device_id *dev_id)
    > +{
    > + struct device *dev = &client->dev;
    > + struct i2c_hid_acpi *ihid_acpi;
    > + u16 hid_descriptor_address;
    > + int ret;
    > +
    > + ihid_acpi = devm_kzalloc(&client->dev, sizeof(*ihid_acpi), GFP_KERNEL);
    > + if (!ihid_acpi)
    > + return -ENOMEM;
    > +

    Turns out one way to find some folks to help me test this code is to
    break them. Maybe not a good way, but a way. :(

    There should have been a:

    ihid_acpi->client = client;

    ...here. If you're willing to look at Chrome OS gerrit pages, you can
    find the fix at <https://crrev.com/c/2527946>.

    If everything about this patch looks good, I'm OK w/ a maintainer
    fixing this when applying. I'm also happy to send out a v6, but I'll
    wait a little bit in case there are other comments.


    -Doug

    \
     
     \ /
      Last update: 2020-11-10 00:24    [W:7.695 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site