lkml.org 
[lkml]   [2020]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v5 1/9] lib: zstd: Add zstd compatibility wrapper
Date


On 6 Nov 2020, at 13:38, Christoph Hellwig wrote:

> You just keep resedning this crap, don't you? Haven't you been told
> multiple times to provide a proper kernel API by now?

You do consistently ask for a shim layer, but you haven’t explained
what we gain by diverging from the documented and tested API of the
upstream zstd project. It’s an important discussion given that we
hope to regularly update the kernel side as they make improvements in
zstd.

The only benefit described so far seems to be camelcase related, but if
there are problems in the API beyond that, I haven’t seen you describe
them. I don’t think the camelcase alone justifies the added costs of
the shim.

-chris

\
 
 \ /
  Last update: 2020-11-09 20:02    [W:1.344 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site