lkml.org 
[lkml]   [2020]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH V4 5/6] PCI: tegra: Check return value of tegra_pcie_init_controller()
    Date
    The return value of tegra_pcie_init_controller() must be checked before
    PCIe link up check and registering debugfs entries subsequently as it
    doesn't make sense to do these when the controller initialization itself
    has failed.

    Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
    ---
    V4:
    * None

    V3:
    * New patch in this series

    drivers/pci/controller/dwc/pcie-tegra194.c | 6 +++++-
    1 file changed, 5 insertions(+), 1 deletion(-)

    diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
    index 9be10c8953df..8c08998b9ce1 100644
    --- a/drivers/pci/controller/dwc/pcie-tegra194.c
    +++ b/drivers/pci/controller/dwc/pcie-tegra194.c
    @@ -1579,7 +1579,11 @@ static int tegra_pcie_config_rp(struct tegra_pcie_dw *pcie)
    goto fail_pm_get_sync;
    }

    - tegra_pcie_init_controller(pcie);
    + ret = tegra_pcie_init_controller(pcie);
    + if (ret < 0) {
    + dev_err(dev, "Failed to initialize controller: %d\n", ret);
    + goto fail_pm_get_sync;
    + }

    pcie->link_state = tegra_pcie_dw_link_up(&pcie->pci);
    if (!pcie->link_state) {
    --
    2.17.1
    \
     
     \ /
      Last update: 2020-11-09 18:21    [W:2.079 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site