lkml.org 
[lkml]   [2020]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] f2fs: avoid unneeded data copy in f2fs_ioc_move_range()
Sorry, please ignore this.

On 11/09, Jaegeuk Kim wrote:
> From: Chao Yu <yuchao0@huawei.com>
>
> Fields in struct f2fs_move_range won't change in f2fs_ioc_move_range(),
> let's avoid copying this structure's data to userspace.
>
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
> fs/f2fs/file.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index 52417a2e3f4f..22ae8ae0072f 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -2898,12 +2898,6 @@ static int f2fs_ioc_move_range(struct file *filp, unsigned long arg)
> range.pos_out, range.len);
>
> mnt_drop_write_file(filp);
> - if (err)
> - goto err_out;
> -
> - if (copy_to_user((struct f2fs_move_range __user *)arg,
> - &range, sizeof(range)))
> - err = -EFAULT;
> err_out:
> fdput(dst);
> return err;
> --
> 2.29.2.222.g5d2a92d10f8-goog

\
 
 \ /
  Last update: 2020-11-09 18:01    [W:0.047 / U:0.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site