Messages in this thread | | | Date | Mon, 9 Nov 2020 17:41:54 +0100 | From | Krzysztof Kozlowski <> | Subject | Re: [PATCH V2] memory: tegra: add missing put_devcie() call in error path of tegra_emc_probe() |
| |
On Mon, Nov 09, 2020 at 09:28:47PM +0800, Yu Kuai wrote: > The reference to device obtained with of_find_device_by_node() should > be dropped. Thus add jump target to fix the exception handling for this > function implementation.
You still need to correct the typo devcie->device in subject, as in v1.
> > Fixes: 73a7f0a90641("memory: tegra: Add EMC (external memory controller) driver") > Signed-off-by: Yu Kuai <yukuai3@huawei.com> > --- > drivers/memory/tegra/tegra124-emc.c | 21 +++++++++++++------ > .../net/ethernet/freescale/fman/fman_port.c | 3 +--
Changes in net are not related, please split... although actually I think the issue is already fixed by 1f1997eb44b1 ("memory: tegra: Add and use devm_tegra_memory_controller_get()").
Best regards, Krzysztof
| |