Messages in this thread | | | From | Matthieu Baerts <> | Subject | Re: [MPTCP][PATCH net 1/2] mptcp: fix static checker warnings in mptcp_pm_add_timer | Date | Mon, 9 Nov 2020 17:28:54 +0100 |
| |
Hi Geliang, Dan,
On 09/11/2020 14:59, Geliang Tang wrote: > Fix the following Smatch complaint:
Thanks for the report and the patch!
> net/mptcp/pm_netlink.c:213 mptcp_pm_add_timer() > warn: variable dereferenced before check 'msk' (see line 208) > > net/mptcp/pm_netlink.c > 207 struct mptcp_sock *msk = entry->sock; > 208 struct sock *sk = (struct sock *)msk; > 209 struct net *net = sock_net(sk); > ^^ > "msk" dereferenced here. > > 210 > 211 pr_debug("msk=%p", msk); > 212 > 213 if (!msk) > ^^^^ > Too late. > > 214 return; > 215 > > Fixes: 93f323b9cccc ("mptcp: add a new sysctl add_addr_timeout") > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > Signed-off-by: Geliang Tang <geliangtang@gmail.com> > Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
A small detail (I think): the Signed-off-by of the sender (Geliang) should be the last one in the list if I am not mistaken. But I guess this is not blocking.
Reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Cheers, Matt -- Tessares | Belgium | Hybrid Access Solutions www.tessares.net
| |