Messages in this thread | | | Date | Mon, 9 Nov 2020 16:10:50 +0000 | From | Lee Jones <> | Subject | Re: [PATCH 10/19] drm/radeon/radeon: Move prototype into shared header |
| |
On Mon, 09 Nov 2020, Sam Ravnborg wrote:
> Hi Lee, > > > > > > Other public functions in radeon_device.c have their prototype in > > > radeon.h - for example radeon_is_px() > > > > > > Add radeon_device_is_virtual() there so we avoiid this new header. > > > > Oh yes, I remember why this wasn't a suitable solution now: > > > > The macro "radeon_init" in radeon.h clashes with the init function of > > the same name in radeon_drv.c: > > > > In file included from drivers/gpu/drm/radeon/radeon_drv.c:53: > > drivers/gpu/drm/radeon/radeon_drv.c:620:31: error: expected identifier or ‘(’ before ‘void’ > > 620 | static int __init radeon_init(void) > ... > > > > How would you like me to move forward? > > Fix the thousand of warnings in other places :-) > I will take a look at radeon and post a new series based on your work > with all W=1 warnings fixed.
I'll drop this patch and carry on ploughing through the rest of them.
-- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
| |