Messages in this thread | | | Subject | Re: [PATCH] net: tcp: ratelimit warnings in tcp_recvmsg | From | Eric Dumazet <> | Date | Mon, 9 Nov 2020 16:39:24 +0100 |
| |
On 11/9/20 3:48 PM, Menglong Dong wrote: > On Mon, Nov 9, 2020 at 9:36 PM Eric Dumazet <edumazet@google.com> wrote: >> >> I do not think this patch is useful. That is simply code churn. >> >> Can you trigger the WARN() in the latest upstream version ? >> If yes this is a serious bug that needs urgent attention. >> >> Make sure you have backported all needed fixes into your kernel, if >> you get this warning on a non pristine kernel. > > Theoretically, this WARN() shouldn't be triggered in any branches. > Somehow, it just happened in kernel v3.10. This really confused me. I > wasn't able to keep tracing it, as it is a product environment. > > I notice that the codes for tcp skb receiving didn't change much > between v3.10 and the latest upstream version, and guess the latest > version can be triggered too. > > If something is fixed and this WARN() won't be triggered, just ignore me. >
Yes, I confirm this WARN() should not trigger.
The bug is not in tcp recvmsg(), that is why you do not see obvious fix for this issue in 3.10
| |