lkml.org 
[lkml]   [2020]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] fs/coda: remove useless varible 'err'
On Fri, Nov 06, 2020 at 10:57:08PM +0800, Alex Shi wrote:
> The variable is unused and cause gcc warning:
> fs/coda/file.c:241:6: warning: variable ‘err’ set but not used
> [-Wunused-but-set-variable]
> So let's remove it.
> Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>
> Cc: Jan Harkes <jaharkes@cs.cmu.edu>
> Cc: coda@cs.cmu.edu
> Cc: codalist@coda.cs.cmu.edu
> Cc: linux-kernel@vger.kernel.org

Looks good to me.

Acked-by: Jan Harkes <jaharkes@cs.cmu.edu>

> ---
> fs/coda/file.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/coda/file.c b/fs/coda/file.c
> index 128d63df5bfb..31a7ba383cb2 100644
> --- a/fs/coda/file.c
> +++ b/fs/coda/file.c
> @@ -238,11 +238,10 @@ int coda_release(struct inode *coda_inode, struct file *coda_file)
> struct coda_file_info *cfi;
> struct coda_inode_info *cii;
> struct inode *host_inode;
> - int err;
>
> cfi = coda_ftoc(coda_file);
>
> - err = venus_close(coda_inode->i_sb, coda_i2f(coda_inode),
> + venus_close(coda_inode->i_sb, coda_i2f(coda_inode),
> coda_flags, coda_file->f_cred->fsuid);
>
> host_inode = file_inode(cfi->cfi_container);
> --
> 1.8.3.1
>
>

\
 
 \ /
  Last update: 2020-11-09 15:42    [W:0.185 / U:0.772 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site